Add support for Android Emacs using Termux#230
Closed
johanwiden wants to merge 2 commits intovedang:masterfrom
johanwiden:feature/android
Closed
Add support for Android Emacs using Termux#230johanwiden wants to merge 2 commits intovedang:masterfrom johanwiden:feature/android
johanwiden wants to merge 2 commits intovedang:masterfrom
johanwiden:feature/android
Conversation
Contributor
Author
|
This is linked to Issue #231 |
Owner
|
Thanks! I'll review this and let you know. The change looks fine. I'll test it and perhaps add a disclaimer that this is not an officially supported platform. |
Contributor
Author
|
Glad to hear. One thing to be aware of: Android touchscreen gestures
currently do not have a good emulation of mouse wheel scroll.
What happens when one puts the finger on the display and then slides the
finger, is that there is an initial mouse click, then scroll events.
As pdf-tools listens for mouse clicks, and then changes mode, this hinders
scrolling with the finger. One can still scroll with a bluetooth mouse
wheel. And one can of course use a keyboard to scroll stepwise.
Den tis 8 aug. 2023 kl 07:43 skrev Vedang Manerikar <
***@***.***>:
… Thanks! I'll review this and let you know.
The change looks fine. I'll test it and perhaps add a disclaimer that this
is not an officially supported platform.
—
Reply to this email directly, view it on GitHub
<#230 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAOF7OLFDOZC7TOEA43WY7TXUHGYPANCNFSM6AAAAAA24MW2XI>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
--
Johan Widén, tel: +46705367346
Risvägen 5 A, 192 73 Sollentuna, SWEDEN
|
|
Exactly what I was looking for ! The fork lets me built epdfinfo server correctly. |
Owner
|
I've rebased your change on top of the latest master, and merged it in. Thank you very much for the PR! |
Contributor
Author
|
I have now verified, on a OnePlus Open android mobile, that I can install the latest version from Melpa, do pdf-tools-install, and then view a pdf file. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add support for pdf-tools-install in Android Emacs using Termux.
The dependencies for android in autobuild can not be installed in pdf-tools-install, they have to be installed manually in Termux. But the dependencies are checked when running autobuild.
pdf-tools-install successfully installs epdfinfo in Android Emacs. One can then view pdf files.
The shebang in autobuild does not work in Termux, I therefore had to create a separate script "autobuild.android" that in turn executes autobuild. The problem with the shebang is that "env" in Termux is not located at "/usr/bin/env".
pdf-tools/Makefile does currently not work in Android Emacs, but it is not needed for running pdf-tools-install. Fixing this will have to be done in a separate pull request, if deemed necessary. Reason: There is yet no consensus for how to implement a command line emacs, to be run in batch mode, in Android Emacs.
I have successfully run "make test" in Ubuntu, in the repo feature branch.
Running "make server-test" in the master branch fails, so I have not tested this in the feature branch.